fix(alerts): Fall through to issue alert handler#116241
Open
ceorourke wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
Scope: Backend
ceorourke
commented
May 26, 2026
| ) | ||
| # Fall through silently: execute_via_group_type_registry catches this | ||
| # and routes to the issue alert handler for action types (e.g. WEBHOOK, | ||
| # PLUGIN, ticketing) that have no metric-alert-specific handler. |
Member
Author
There was a problem hiding this comment.
I think this makes sense, at least it makes more sense than adding new metric issue specific handlers for these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a metric detector's action is webhook (or any non-explicitly supported action type) we hit a
NoRegistrationExistserror. If we let it fall through it will route to the issue alert handler it should be handled appropriately.Fixes https://sentry.sentry.io/issues/7230559910/