feat(issues): Add action log instrumentation with source attribution#116244
Closed
yuvmen wants to merge 10 commits into
Closed
feat(issues): Add action log instrumentation with source attribution#116244yuvmen wants to merge 10 commits into
yuvmen wants to merge 10 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
yuvmen
force-pushed
the
yuvmen/issue-action-log-instrumentation
branch
from
eff9ad6 to
f068622
Compare
Add `resolve_action_source(request)` to detect the caller surface (MCP agents, Seer, web UI, sentry-cli, API) and `publish_action()` as a no-op logger for issue mutations. Instrument the core write paths: - resolve/unresolve/archive via update_groups handlers - assign, priority, bookmark, subscribe, merge, mark_reviewed - view (GroupDetailsEndpoint.get) - trigger_autofix (GroupAutofixEndpoint.post) Actions are only emitted when a mutation actually occurs, following the same gates as Activity creation. Source is resolved once per request and threaded through to each handler.
yuvmen
force-pushed
the
yuvmen/issue-action-log-instrumentation
branch
from
f068622 to
a50d729
Compare
Import ApiClient and ApiError directly instead of using the client module as a namespace, which mypy cannot resolve attributes on.
yuvmen
commented
May 26, 2026
| from sentry.snuba.referrer import Referrer | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
| client = ApiClient() |
Member
Author
There was a problem hiding this comment.
was getting typing errors on all these tool files, have no idea why when main has them go through fine. Eventually gave up and fixed the typing issue here, seems like import was too ambigious
https://github.com/getsentry/sentry/actions/runs/26478542633/job/77970203553
Derive ActorType (USER/SYSTEM) from actor_id to align with Kyle's GroupActionLogEntry model which stores actor_type as a separate field.
Aligns with the Issue Action Log spec requirement that every event has a stable client-supplied id for deduplication.
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
- Priority: only emit SET_PRIORITY when group priority actually differs - Assign: snapshot assignees before/after, skip when unchanged - Merge: emit MERGE_FROM_OTHER on survivor, MERGE_INTO_OTHER on each absorbed group with counterpart metadata - Mark reviewed: only emit for groups that were actually in inbox - Add integration tests for all mutation paths including no-op cases
Read parent/children from handle_merge return value instead of assuming group_list[0] is the primary — handle_merge sorts by first_seen, event count, and id to pick the survivor.
- Cache negative _get_mcp_application_id result to avoid DB query per request when no MCP app exists - Only emit unresolve/archive actions for groups whose status actually changed, matching the queryset.exclude(status=new_status) gate
- Remove unused MCP_CLIENT_ID_HEADER constant - Move changed_group_ids query inside transaction to avoid race - Add tests for archive/unresolve already-at-target-status skipping - Add test for unassign with existing assignee emitting action
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 87798be. Configure here.
…dler - Bookmark: snapshot existing bookmarks, only log for newly created - Subscribe: snapshot current subscription state, skip when unchanged - Merge: guard against mocked merge result in tests (isinstance check) - Add tests for bookmark/subscribe idempotency
Member
Author
|
Did some rethinking and I think this ended up being kind of clusmy, I tried to avoid getting tied to the way Activity is being created and try to unify some paths, but ended up needing a bunch of logic to avoid duplication of reporting. Going to open a new PR to clean up all the noise here and start fresh sticking closer to where we create Activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up the instrumentation that currently doesnt actually write anywhere other than log and metrics, but lays the groundwork making it easy to just swap in the actual recording when we are ready.
resolve_action_source(request)to detect caller surface: MCP agents (gated onapplication_id), Seer (viaX-Seer-Referreror RPC auth), web UI, sentry-cli, generic APIpublish_action()no-op logger for issue mutations — will be wired torecord_group_action()when feat(issues): Add GroupActionLogEntry #115771 landsActivitycreation:prepare_responsehandlers)GroupDetailsEndpoint.get)GroupAutofixEndpoint.post)