fix(replays): Remove timeline icon z-index workaround#116255
Conversation
Add a story for the marker column layout so the timeline API is easier to inspect in Storybook. Also keeps replay's icon z-index local to the replay breadcrumb connector instead of baking that stacking into every timeline icon. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.58% |
Replay breadcrumbs were drawing the connector as an overlapping pseudo-element, so the timeline icon needed a z-index to sit above it. Draw the connector as a row background instead. That keeps the line behind the icon without making every timeline icon participate in dropdown stacking. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
scttcper
changed the title
Keep this PR focused on the replay z-index cleanup. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
The replay breadcrumb connector is a background now, so the wrapper no longer needs relative positioning. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cc868bf. Configure here.
| maxHeight: 142, | ||
| minWidth: 220, | ||
| overflow: 'auto', | ||
| zIndex: theme.zIndex.dropdown, |
There was a problem hiding this comment.
Mention list under timeline
Medium Severity
Removing zIndex: theme.zIndex.dropdown from the react-mentions suggestions list style drops the @-mention menu below later siblings in normal paint order. In issue activity, NoteInput sits above Timeline.Container, and inline edits sit inside a row while following rows still render after—so suggestions can be covered and hard to use.
Reviewed by Cursor Bugbot for commit cc868bf. Configure here.
2 participants
removes stacking fight by drawing replay's breadcrumb connector as a row background instead of an overlapping element
refs #116209 that was the wrong solution