chore(relocation) Exclude Email model from relocations v2 #116256
Merged
Conversation
)" This reverts commit 8a17856.
Redo of #116226 which I reverted because it caused test failures on master that weren't caught by selective testing. --- This model frequently blocks relocations for import/export differences, and I'd like that to not happen anymore. The Email model is populated by signals on create/delete operations to UserEmail it does not synchronize state on updates, and there are several older user accounts that are missing records in sentry_email that are present in sentry_useremail which cause relocations to fail. By excluding this model from exports, these records won't participate in the validation checks and can't cause diffs. When the relocation is processed records will still be stored in sentry_email because of the aformentioned signals.
github-actions
Bot
added
the
Scope: Backend
markstory
commented
May 26, 2026
| assert not findings | ||
|
|
||
|
|
||
| def test_bad_missing_custom_ordinal() -> None: |
Member
Author
There was a problem hiding this comment.
The tests in this file are the ones that failed. I've removed this test as it was covering a different error, and we have other tests covering the duplicate ordinals and incorrect ordinal values.
| """ | ||
| { | ||
| "model": "sentry.email", | ||
| "model": "sentry.sentryapp", |
Member
Author
There was a problem hiding this comment.
This is the only other model I could find using the obfuscating comparator.
wedamija
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of #116226 which I reverted because it caused test failures on master that weren't caught by selective testing.
This model frequently blocks relocations for import/export differences,
and I'd like that to not happen anymore.
The Email model is populated by signals on create/delete operations to UserEmail it does not synchronize state on updates, and there are several older user accounts that are missing records in sentry_email that are present in sentry_useremail which cause relocations to fail.
By excluding this model from exports, these records won't participate in the validation checks and can't cause diffs. When the relocation is processed records will still be stored in sentry_email because of the aformentioned signals.