fix(conversations): Restore side-by-side layout for platform option dropdown#116272
Merged
priscilawebdev merged 1 commit intoMay 27, 2026
Conversation
…ropdown The recent scraps primitives refactor replaced the `<Flex>` wrapper around `PlatformOptionDropdown` with a `<Stack>` that now wraps the whole onboarding content. Because `PlatformOptionDropdown` returns a Fragment with the "with" text and the dropdown as siblings, the Stack hoisted them as separate vertical items, breaking the inline row. Wrap just the dropdown in a `<Flex gap="md" align="center" wrap="wrap">` inside the Stack so the label and selector render on the same line again. Refs GH-116082
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.58% |
shellmayr
approved these changes
May 27, 2026
priscilawebdev
deleted the
priscilawebdev/fix/conversations-conversations-onboarding-with-selector-layout
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the inline
with <SDK>layout on the conversations onboarding panel.In #116082 the
<Flex gap="md" align="center" wrap="wrap" paddingBottom="md">wrapper aroundPlatformOptionDropdownwas replaced by a<Stack gap="md">that now wraps the dropdown, the introduction, and the guided steps together.PlatformOptionDropdownreturns a Fragment containing the"with"text node and theOptionControldropdown(s) as siblings — so the Stack hoisted them as separate vertical items and the label ended up above the selector.Wrap just the dropdown row in a
<Flex gap="md" align="center" wrap="wrap">inside the Stack. The Stack's owngap="md"already handles spacing to the next row, so the previouspaddingBottom="md"is no longer needed.Refs GH-116082