Skip to content

fix(tests): don't include trace context in symbolicator snapshots#116275

Merged
shellmayr merged 4 commits into
masterfrom
shellmayr/fix/update-symbolicator-snapshot-tests
May 27, 2026
Merged

fix(tests): don't include trace context in symbolicator snapshots#116275
shellmayr merged 4 commits into
masterfrom
shellmayr/fix/update-symbolicator-snapshot-tests

Conversation

@shellmayr
Copy link
Copy Markdown
Member

@shellmayr shellmayr commented May 27, 2026

  • Changes necessary due to a change in relay
  • Example for failing tests on some PRs
  • Snapshots generated using SENTRY_SNAPSHOTS_WRITEBACK=new pytest tests/symbolicator/ locally with devservices relay and symbolicator ended up being volatile (unique IDs)
  • Use approach to exclude the trace context from the snapshot as has been done with the reprocessing context

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 27, 2026
@shellmayr shellmayr marked this pull request as ready for review May 27, 2026 08:27
@shellmayr shellmayr requested a review from a team as a code owner May 27, 2026 08:27
@shellmayr shellmayr requested a review from a team May 27, 2026 08:27
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1b40f1f. Configure here.

@shellmayr shellmayr changed the title fix(tests): update symbolicator snapshot tests fix(tests): don't include trace context in symbolicator snapshots May 27, 2026
@shellmayr shellmayr added the Trigger: Override Selective Testing Run the full test suite; necessary in cases where selected tests are flaky due to reshuffling label May 27, 2026
@shellmayr shellmayr merged commit a3fd473 into master May 27, 2026
126 of 131 checks passed
@shellmayr shellmayr deleted the shellmayr/fix/update-symbolicator-snapshot-tests branch May 27, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Trigger: Override Selective Testing Run the full test suite; necessary in cases where selected tests are flaky due to reshuffling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants