feat(scm): add check_suite and pull_request_review to event stream#116326
Open
joseph-sentry wants to merge 4 commits into
Open
feat(scm): add check_suite and pull_request_review to event stream#116326joseph-sentry wants to merge 4 commits into
joseph-sentry wants to merge 4 commits into
Conversation
add serializers, deserializers and update functions to handle new event types in a follow up change i will create the concrete listeners that will handle these events but this just sets it up so in the next change i just have to implement the listener Fixes CW-1406 Fixes CW-1390
github-actions
Bot
added
the
Scope: Backend
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
PullRequestReviewEvent requires author and is_bot fields but the parser, serializer, and deserializer were missing them, causing TypeError at runtime for every pull_request_review listener task.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d190ef6. Configure here.
…uest_review - Use pr.number instead of pr.id for pull_request_ids in check_suite and pull_request_id in pull_request_review to match PR event's str(e.number) - Capture html_url instead of url from GitHub check_suite payload - Add assert_never fallback to deserialize_github_event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add serializers, deserializers and update functions to handle new event types
in a follow up change i will create the concrete listeners that will handle these
events but this just sets it up so in the next change i just have to implement the
listener
Fixes CW-1406
Fixes CW-1390