fix(api-logs): log snuba throttle_threshold on rate-limited requests#116338
Merged
cvxluo merged 1 commit intoMay 27, 2026
Merged
Conversation
Snuba's quota_allowance summary exposes rejection_threshold under rejected_by but throttle_threshold under throttled_by. We were only plumbing rejection_threshold, so api access logs for throttled-only 429s were missing the threshold value entirely. Add throttle_threshold to RateLimitExceeded, SnubaRateLimitMeta, and the access log payload as snuba_throttle_threshold, mirroring the existing rejection field. Co-authored-by: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
wedamija
approved these changes
May 27, 2026
cvxluo
deleted the
cvxluo/log-snuba-throttle-threshold-on-rate-limited-reque
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #116263. Log the throttled threshold when we get a 429 response due to throttling from snuba.