fix(dashboards): Move global filter loading spinner to dropdown footer#116342
Merged
DominikB2014 merged 3 commits intoMay 29, 2026
Conversation
The global filter dropdown trigger replaced the selected value with a spinner while tag values refetched as the user typed. This was confusing because the selected value had not changed. Keep the selected value visible in the trigger and surface the loading state as a small indicator at the bottom of the dropdown list instead. Refs DAIN-1636 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.59% |
The filter selector trigger now always displays the selected value (or "All"), so the accessible names of the trigger buttons include that text in tests. Co-Authored-By: Claude <noreply@anthropic.com>
…sBar The global filter trigger no longer renders a loading indicator while tag values fetch, so waitForElementToBeRemoved on that testid errors immediately. Wait for the filter trigger button to appear instead. Co-Authored-By: Claude <noreply@anthropic.com>
mjq
approved these changes
May 29, 2026
DominikB2014
deleted the
dominikbuszowiecki/dain-1636-global-filter-shifts-back-and-forth-on-dashboard
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the loading indicator from dropdown trigger to the dropdown list. This is exactly how the other search bars handle it (for example searching in the explore search bar). This resolves two issues:
Before
After
Refs DAIN-1636