ref(seer): Unify Seer project settings update helper and add tuning and auto_create_pr fields by srest2021 · Pull Request #116352 · getsentry/sentry

srest2021 · 2026-05-27T22:18:57Z

Consolidate update_seer_project_settings and bulk_update_seer_project_settings into a single function
that bulk deletes/creates project options across 1+ project ids. Also, strip seat-based business logic (stopping point → auto_create_pr syncing, tuning validation) out of the update helper and add tuning and auto_create_pr as update fields, so it becomes a pure write layer and can be used by other callsites.

Followups: #116356, #115962

Why:

By moving business logic out, other callsites can do updates without hidden side effects.

Independent auto_create_pr and tuning updates are needed by legacy seer and will be used when we add legacy seer to the project settings endpoints: feat(settings): Support legacy usage-based Seer in project settings endpoint #115962
ref(seer): Call project settings update helper in callsites that don't need to update the full Seer project preference #116356 reroutes existing callsites that modify seer project settings (_write_preferences_to_sentry_db, configure_seer_for_existing_org, set_default_project_seer_preferences) to the update helper to ensure that handoff options are either cleared or added atomically AND to skip unnecessary connected repo operations. It also removes Project row locks and simplifies clear_preference_automation_handoff.

Other cleanups:

SeerProjectSettingsUpdate uses snake_case keys via CamelSnakeSerializer.
Add tuning to the project settings endpoints serializers (as opposed to consolidating tuning="off" into stopping_point="off"), again to make it easier to support legacy seer.
Endpoint returns autoCreatePr and automationTuning in response.
Stopping point syncs auto_create_pr automatically.

srest2021 · 2026-05-27T23:24:42Z

+    automation_tuning = serializers.ChoiceField(
+        choices=[AutofixAutomationTuningSettings.OFF, AutofixAutomationTuningSettings.MEDIUM],
+        required=False,
+    )


It's easier to keep stopping point and tuning as independent fields, so that we can support legacy seer which allows other tuning values besides "off" and "medium".

srest2021 · 2026-05-27T23:25:02Z

+        # Keep stopping point in sync with handoff auto_create_pr.
+        if "stopping_point" in data and "auto_create_pr" not in data:
+            data["auto_create_pr"] = data["stopping_point"] == AutofixStoppingPoint.OPEN_PR
+


Here we keep auto_create_pr in sync with the stopping point before we pass the serializer data to update_seer_project_settings.

JoshFerge

I'm finding it a bit difficult to review, as there are a few threads to follow in this PR

Consolidate update_seer_project_settings and bulk_update_seer_project_settings into a single function
Strip seat-based business logic
add tuning and auto_create_pr as update fields
SeerProjectSettingsUpdate uses snake_case keys via CamelSnakeSerializer.
Add tuning to the project settings endpoints serializers (as opposed to consolidating tuning="off" into stopping_point="off"), again to make it easier to support legacy seer.
Endpoint returns autoCreatePr and automationTuning in response.
Stopping point syncs auto_create_pr automatically.

Could this PR be broken down further, or do all these changes need to go in together?

…ializer

…taking project_ids

…ct_settings

…er with auto_create_pr sync

JoshFerge

looks great! appreciate breaking it out by commit, super easy to review! just a couple minor comments

…ndpoint (#115962) Depends on #116352 and #116356. Add legacy usage-based Seer support to the project settings endpoints by branching on `is_seer_seat_based_tier_enabled`. **Serializer split:** - Extract `_BaseProjectSettingsUpdateSerializer` with shared validation (agent, integration_id, cross-field checks) - `ProjectSettingsUpdateSerializer` (seat-based): restricted tuning choices (off/medium), stopping_point validation via `get_valid_automated_run_stopping_points`, auto_create_pr synced from stopping_point - `LegacyProjectSettingsUpdateSerializer` (usage-based): accepts all tuning values, direct `auto_create_pr` field, no stopping_point restrictions ### Example payloads **Set tuning to a granular value:** ```json PUT /api/0/projects/{org}/{project}/seer/settings/ {"automationTuning": "high"} ``` **Set stopping point (frontend sends agent=seer to clear any external handoff):** ```json PUT /api/0/projects/{org}/{project}/seer/settings/ {"stoppingPoint": "code_changes", "agent": "seer"} ``` This clears handoff keys (target, point, integration_id) but preserves `auto_create_pr` so switching back to an external agent restores the previous toggle value. **Switch to external agent with auto_create_pr:** ```json PUT /api/0/projects/{org}/{project}/seer/settings/ {"agent": "cursor_background_agent", "integrationId": 1, "autoCreatePr": true} ``` **Toggle auto_create_pr on an existing external agent:** ```json PUT /api/0/projects/{org}/{project}/seer/settings/ {"autoCreatePr": false} ``` **Turn off automation:** ```json PUT /api/0/projects/{org}/{project}/seer/settings/ {"automationTuning": "off"} ``` GET response will show `stoppingPoint: "off"`, but the stored stopping point is unchanged — re-enabling restores it.

…t need to update the full Seer project preference (#116356) Followup to #116352. Reroute existing callsites that modify seer project settings (`_write_preferences_to_sentry_db`, `configure_seer_for_existing_org`, `set_default_project_seer_preferences`) to the unified `update_seer_project_settings` helper. This ensures handoff options are cleared/added atomically and skips unnecessary connected repo operations. Also remove `Project` row locks from `_write_preferences_to_sentry_db` and `clear_preference_automation_handoff` — no longer needed since handoff options are all either cleared or added atomically, and the other update fields may be updated independently of each other.

github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 27, 2026

sentry-warden Bot reviewed May 27, 2026

View reviewed changes

Comment thread src/sentry/seer/similarity/utils.py Outdated

srest2021 changed the title ~~ref(seer): unify update_seer_project_settings and add autoCreatePr/automationTuning~~ ref(seer): Unify Seer project settings helper and add tuning and auto_create_pr fields May 27, 2026

srest2021 changed the title ~~ref(seer): Unify Seer project settings helper and add tuning and auto_create_pr fields~~ ref(seer): Unify Seer project settings update helper and add tuning and auto_create_pr fields May 27, 2026

srest2021 mentioned this pull request May 27, 2026

feat(settings): Support legacy usage-based Seer in project settings endpoint #115962

Merged

srest2021 commented May 27, 2026

View reviewed changes

srest2021 mentioned this pull request May 28, 2026

ref(seer): Call project settings update helper in callsites that don't need to update the full Seer project preference #116356

Merged

srest2021 marked this pull request as ready for review May 28, 2026 16:48

srest2021 requested a review from a team as a code owner May 28, 2026 16:48

sentry Bot reviewed May 28, 2026

View reviewed changes

Comment thread src/sentry/seer/endpoints/project_seer_settings.py

Comment thread src/sentry/seer/endpoints/project_seer_settings.py

JoshFerge reviewed May 28, 2026

View reviewed changes

srest2021 added 4 commits May 28, 2026 15:00

ref(seer): rename settings fields to snake_case and use CamelSnakeSer…

460fd64

…ializer

ref(seer): unify update_seer_project_settings into a single function …

f5eccf4

…taking project_ids

ref(seer): strip stopping_point business logic from update_seer_proje…

fc26fed

…ct_settings

ref(seer): add autoCreatePr/automationTuning to response and serializ…

f682313

…er with auto_create_pr sync

srest2021 marked this pull request as draft May 28, 2026 22:24

srest2021 force-pushed the srest2021/ref-update-settings-pt1 branch from dc236fb to f682313 Compare May 28, 2026 22:24

srest2021 marked this pull request as ready for review May 28, 2026 22:32

JoshFerge reviewed May 28, 2026

View reviewed changes

Comment thread src/sentry/seer/autofix/utils.py Outdated

JoshFerge reviewed May 28, 2026

View reviewed changes

Comment thread src/sentry/seer/autofix/utils.py

JoshFerge approved these changes May 28, 2026

View reviewed changes

srest2021 and others added 2 commits May 29, 2026 09:46

fix camel case in validation errors

9f45557

Merge branch 'master' into srest2021/ref-update-settings-pt1

e0a4c7c

vercel Bot deployed to Preview May 29, 2026 16:50 View deployment

srest2021 merged commit c8dc13c into master May 29, 2026
69 checks passed

srest2021 deleted the srest2021/ref-update-settings-pt1 branch May 29, 2026 17:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ref(seer): Unify Seer project settings update helper and add tuning and auto_create_pr fields#116352

ref(seer): Unify Seer project settings update helper and add tuning and auto_create_pr fields#116352
srest2021 merged 6 commits into
masterfrom
srest2021/ref-update-settings-pt1

srest2021 commented May 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

srest2021 May 27, 2026

Uh oh!

srest2021 May 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

JoshFerge left a comment

Uh oh!

Uh oh!

Uh oh!

JoshFerge left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

srest2021 commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why:

Other cleanups:

Uh oh!

Uh oh!

srest2021 May 27, 2026

Choose a reason for hiding this comment

Uh oh!

srest2021 May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshFerge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshFerge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

srest2021 commented May 27, 2026 •

edited

Loading

srest2021 May 27, 2026 •

edited

Loading