feat(issues): Restore issue details tour, remove guide#116355
Merged
Conversation
The old issue details guide was still wired into anchors that no longer exist, while the current tour had no launcher when the backend marked it unseen. Remove the stale guide and anchor wrappers, keep the existing tour, and lazy-load the start tour modal when the backend says to show it. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.59% |
scttcper
changed the title
The issue details guide is gone, so use the existing trace guide as the replacement fixture. Render all of its anchors so the test covers the actual guide flow instead of depending on missing-step filtering.
roggenkemper
approved these changes
May 29, 2026
Member
roggenkemper
left a comment
roggenkemper
left a comment
There was a problem hiding this comment.
overall looks good and works as intended - only comment is i wonder if this tour should also highlight the copy button
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
837
to
841
| orderedStepIds={ORDERED_ISSUE_DETAILS_TOUR} | ||
| TourContext={IssueDetailsTourContext} | ||
| > | ||
| <IssueDetailsTourModal /> | ||
| <GroupDetailsContent |
Contributor
There was a problem hiding this comment.
Bug: The issue details tour modal will not open for SOURCEMAP_CONFIGURATION and LOW_VALUE_SPAN_CONFIGURATION issues because some required tour steps are conditionally rendered and never register.
Severity: MEDIUM
Suggested Fix
Consider setting the requireAllStepsRegistered prop on TourContextProvider to false to allow the tour to run with a subset of steps. Alternatively, conditionally register tour steps based on the issue type's configuration, ensuring that only available steps are expected by the tour context for the tour to be considered 'registered'.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: static/app/views/issueDetails/groupDetails.tsx#L837-L841
Potential issue: The `TourContextProvider` is configured with
`requireAllStepsRegistered` set to `true`, meaning all tour steps must be registered
before the tour can start. However, for `SOURCEMAP_CONFIGURATION` and
`LOW_VALUE_SPAN_CONFIGURATION` issue types, the `filterBar` and `eventNavigation` are
disabled in their configuration. This prevents the `IssueDetailsTour.FILTERS` and
`IssueDetailsTour.NAVIGATION` steps from being rendered and registered. Consequently,
the `isRegistered` state in the tour context never becomes `true`. The
`useIssueDetailsTourModal` hook includes a check `if (!isRegistered || ...)` which then
prevents the tour modal from ever being displayed for these issue types, even when
forced via a URL hash.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old issue details guide was still wired into anchors that no longer exist, while the current tour had no launcher when the backend marked it unseen.
Removes the stale guide and anchor wrappers, keeps the existing tour, and lazy-loads the start tour modal when we should show it.
Brings back the tour, can be manually triggered
#issue-details-touron the issue details page