Skip to content

chore(codeowners): reuse get_projects in associations endpoint #116359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giovanni-guidini merged 1 commit into from
May 28, 2026
Merged

chore(codeowners): reuse get_projects in associations endpoint #116359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/sentry/issues/endpoints/organization_codeowners_associations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@
OrganizationIntegrationsLoosePermission,
)
from sentry.api.validators.project_codeowners import build_codeowners_associations
from sentry.constants import ObjectStatus
from sentry.integrations.services.integration import integration_service
from sentry.models.organization import Organization
from sentry.models.project import Project
from sentry.models.projectcodeowners import ProjectCodeOwners


Expand All @@ -30,10 +28,7 @@ def get(self, request: Request, organization: Organization) -> Response:
Returns all ProjectCodeOwners associations for an organization as a dict with projects as keys
e.g. {"projectSlug": {associations: {...}, errors: {...}}, ...]
"""
projects = Project.objects.filter(
organization=organization,
status=ObjectStatus.ACTIVE,
)
projects = self.get_projects(request, organization)
Comment thread
giovanni-guidini marked this conversation as resolved.
Comment thread
giovanni-guidini marked this conversation as resolved.
project_code_owners = ProjectCodeOwners.objects.filter(project__in=projects)
provider = request.GET.get("provider")
if provider:
Expand Down
Loading