fix(feedback): Make UserReport name and email nullable#116362
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.59% |
TkDodo
commented
May 28, 2026
Comment on lines
+39
to
+43
| onClick={() => | ||
| copy(report.email ?? '', { | ||
| successMessage: t('Copied email to clipboard'), | ||
| }) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
inlined to make it more obvious that report.email is checked above
priscilawebdev
approved these changes
May 28, 2026
mujacica
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend
UserReportSerializerreturnsnameandemailasstr | None, but the frontendUserReporttype had both as non-nullablestring. When either field isnull,isSameIdentitycrashes calling.trim()onnull.Updates the frontend type to match the backend and adds null-handling in
userFeedback.tsx— optional chaining inisSameIdentity, null-coalescing for avatar fallbacks, and conditionally rendering the email copy button.Fixes JAVASCRIPT-3A0C