fix(logs): Pass timestamp to trace item details#116374
Merged
nsdeschenes merged 8 commits intoMay 28, 2026
Merged
Conversation
Allow trace item details callers to pass a unix timestamp so lookup can be scoped to the relevant trace item occurrence. Existing callers omit the value and keep the previous request shape. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Use the metric sample timestamp when fetching trace item details so the request matches trace meta scoping. Add a regression assertion for the expanded sample details request. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Use the page filter datetime selection when trace item details do not receive an explicit item timestamp. Keep explicit metric sample timestamps as the more specific lookup key and cover the shared hook behavior with focused tests. Refs LOGS-828 Co-Authored-By: OpenAI Codex <noreply@openai.com>
Treat null trace item timestamps the same as missing timestamps so page-filter datetime params are sent as the fallback. This keeps statsPeriod available when no specific timestamp is present while preserving zero as a valid timestamp. Co-Authored-By: Codex <noreply@openai.com>
Use renderHook initialProps in the trace item details hook tests and move project store setup into beforeEach. This keeps the test setup explicit after adding null timestamp coverage. Co-Authored-By: Codex <noreply@openai.com>
Use the log row timestamp for trace item detail lookups from both hover prefetch and expanded row details. This lets the detail request disambiguate the item without relying on page filter time params. Co-Authored-By: Codex <noreply@openai.com>
Assert that log row detail requests include the row timestamp for both hover prefetch and expanded row details. This protects the timestamp-specific lookup behavior. Co-Authored-By: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
Author
|
@sentry review |
Contributor
Author
|
@cursor review |
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.59% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 291adb9. Configure here.
Base automatically changed from
nd/LOGS-828/fix-metrics-pass-timestamp-to-trace-item-details
to
master
May 28, 2026 17:10
…/fix-logs-pass-timestamp-to-trace-item-details # Conflicts: # static/app/views/explore/metrics/metricPanel/index.spec.tsx
narsaynorath
approved these changes
May 28, 2026
nsdeschenes
deleted the
nd/LOGS-829/fix-logs-pass-timestamp-to-trace-item-details
branch
nsdeschenes
added a commit
that referenced
this pull request
May 28, 2026
Fixing issue with failing log tests introduced in: #116374 Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wires up the logs query to pass the
timestampwhile fetching the trace item details for a given log.Closes LOGS-829
Requires: #116315