feat(span-fields): Hide internal attributes#116384
Open
nsdeschenes wants to merge 2 commits into
Open
Conversation
Use the API-facing span attribute visibility helper for the legacy spans fields endpoint so internal Sentry convention attributes are not exposed to non-staff users. Refs EXP-973 Co-Authored-By: Codex <noreply@openai.com>
Add endpoint coverage for the legacy spans fields API so internal Sentry convention attributes remain hidden while public attributes are returned. Refs EXP-973 Co-Authored-By: Codex <noreply@openai.com>
Contributor
Author
|
@cursor review |
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 524f459. Configure here.
adrianviquez
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to hide "internal" attributes as defined in sentry conventions from being returned in API responses.
Closes EXP-973