chore(github-enterprise): Remove fully-GA github.com source flag checks#116385
Merged
Conversation
The `organizations:github-enterprise-github-com-source` flag is at 100% rollout (segment `GA`, no conditions) in flagpole. Drop the `features.has` guards in both the form-based `InstallationConfigView` and the API-driven `GHEInstallationConfigApiStep`, and the tests that exercised the rejection path. github.com installs now succeed for every organization. This is step 1 of the standard flagpole removal order. Follow-up PRs will remove the flag config from sentry-options-automator and the registration from `temporary.py`.
github-actions
Bot
added
the
Scope: Backend
billyvg
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
features.has("organizations:github-enterprise-github-com-source", ...)guards from the two GHE setup pipelines (form-basedInstallationConfigViewand API-drivenGHEInstallationConfigApiStep), along with the tests that exercised the rejection path.The flag is at 100% rollout (segment
GA, no conditions) in flagpole, so every org already passes the check — removing it makes that explicit and lets us proceed with the standard flagpole removal sequence.This is step 1 of three. Follow-ups:
feature.organizations:github-enterprise-github-com-sourceblock fromsentry-options-automator/options/default/flagpole.yaml.manager.add(...)registration fromsrc/sentry/features/temporary.py.Each waits for the previous to deploy.