Skip to content

feat(waterfall): Add visual indication for SDK-sent v2 spans#116386

Open
Lms24 wants to merge 3 commits into
masterfrom
lms/feat-waterfall-v2-indication
Open

feat(waterfall): Add visual indication for SDK-sent v2 spans#116386
Lms24 wants to merge 3 commits into
masterfrom
lms/feat-waterfall-v2-indication

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented May 28, 2026

At the moment, there's no intuitive way for users to know that a span they're looking at comes from an SDK they configured for span streaming as opposed to from an SDK-sent transaction that was converted to EAP spans. This makes it hard for users to verify, without deeply debugging their SDK, that they migrated their SDKs correctly.

So my thinking is, we can (for a while) add a small hint that this is in fact the case, which our Span Streaming migration docs (WIP, see getsentry/sentry-docs#17834) can include in the ## Verify section. This PR proposes to add the broadcast icon and a "Streamed Span" tooltip when hovering over the icon in the details panel of the trace waterfall.

How do we distinguish SDK-sent vs. transaction-converted EAP spans? By checking for the presence of the observed_timestamp_nanos attribute which is only present on SDK-sent spans.

UPDATE: I also had to add an additional attribute check to distinguish v2 from v1 spans because they look almost identically. What I ended up with: We can identify v1 web vital spans based on them having the report_event attribute. V2 spans no longer have this attribute, so it should be enough to distinguish them. This works because AFAIK, we only send web vital spans as standalone v1 spans.

I'm happy to change or drop this PR if anyone has concerns, but figured I'd open it anyway, since it was a quick change. Also have some alternative suggestions (see the Slack thread).

image image

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.59%

@Lms24 Lms24 self-assigned this May 28, 2026
@Lms24 Lms24 marked this pull request as ready for review May 28, 2026 16:37
@Lms24 Lms24 requested a review from a team as a code owner May 28, 2026 16:37
Comment thread static/app/views/performance/newTraceDetails/traceDrawer/details/span/index.tsx Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 675f4a2. Configure here.

Comment thread static/app/views/performance/newTraceDetails/traceDrawer/details/span/index.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants