feat(waterfall): Add visual indication for SDK-sent v2 spans#116386
Open
Lms24 wants to merge 3 commits into
Open
feat(waterfall): Add visual indication for SDK-sent v2 spans#116386Lms24 wants to merge 3 commits into
Lms24 wants to merge 3 commits into
Conversation
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.59% |
6 tasks
nsdeschenes
approved these changes
May 28, 2026
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 675f4a2. Configure here.
nsdeschenes
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

At the moment, there's no intuitive way for users to know that a span they're looking at comes from an SDK they configured for span streaming as opposed to from an SDK-sent transaction that was converted to EAP spans. This makes it hard for users to verify, without deeply debugging their SDK, that they migrated their SDKs correctly.
So my thinking is, we can (for a while) add a small hint that this is in fact the case, which our Span Streaming migration docs (WIP, see getsentry/sentry-docs#17834) can include in the
## Verifysection. This PR proposes to add the broadcast icon and a "Streamed Span" tooltip when hovering over the icon in the details panel of the trace waterfall.How do we distinguish SDK-sent vs. transaction-converted EAP spans? By checking for the presence of the
observed_timestamp_nanosattribute which is only present on SDK-sent spans.UPDATE: I also had to add an additional attribute check to distinguish v2 from v1 spans because they look almost identically. What I ended up with: We can identify v1 web vital spans based on them having the
report_eventattribute. V2 spans no longer have this attribute, so it should be enough to distinguish them. This works because AFAIK, we only send web vital spans as standalone v1 spans.I'm happy to change or drop this PR if anyone has concerns, but figured I'd open it anyway, since it was a quick change. Also have some alternative suggestions (see the Slack thread).