Skip to content

feat(replays): Add superuser replay debugger dropdown option#116391

Merged
billyvg merged 2 commits into
masterfrom
billy/feat-replay-add-superuser-open-in-sentry-replay-debugger
May 28, 2026
Merged

feat(replays): Add superuser replay debugger dropdown option#116391
billyvg merged 2 commits into
masterfrom
billy/feat-replay-add-superuser-open-in-sentry-replay-debugger

Conversation

@billyvg
Copy link
Copy Markdown
Member

@billyvg billyvg commented May 28, 2026

  • Add a new "Debug in Sentry Replay Debugger" dropdown menu item for superusers/employees in the replay detail view that opens the Sentry Replay Debugger macOS app
  • Replace (superuser) text with FeatureBadge debug variant on existing superuser-only menu items
image

billyvg and others added 2 commits May 28, 2026 11:27
Add a new dropdown menu item for superusers/employees to open replay
data in the Sentry Replay Debugger macOS app. The option copies rrweb
frames JSON to clipboard and opens the app via custom URI scheme.

Also replace '(superuser)' text with FeatureBadge debug variant on
existing superuser-only menu items.

Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 28, 2026
@billyvg billyvg marked this pull request as ready for review May 28, 2026 15:59
@billyvg billyvg requested a review from a team as a code owner May 28, 2026 15:59
@github-actions
Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.59%

Comment on lines +104 to +114
<span>
{tct('Debug in [link]', {
link: (
<ExternalLink href="https://github.com/getsentry/replay-debugger/releases">
{t('Sentry Replay Debugger')}
</ExternalLink>
),
})}
</span>
<FeatureBadge type="debug" />
</Flex>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Placing an ExternalLink inside a menu item's label alongside an onAction handler creates conflicting click behaviors and an unpredictable user experience.
Severity: MEDIUM

Suggested Fix

To resolve the ambiguity, either remove the ExternalLink from the label if the onAction is the intended primary action, or use the externalHref prop on the menu item itself if the goal is to navigate. Alternatively, handle the click on the ExternalLink separately with its own stopPropagation to prevent the menu item's action from firing.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location:
static/app/views/explore/replays/detail/header/replayItemDropdown.tsx#L101-L114

Potential issue: A new menu item, "Debug in Sentry Replay Debugger", is configured with
an `onAction` handler. Simultaneously, its `label` contains a nested `ExternalLink`
component, which renders an `<a>` tag. The parent menu item does not have an
`externalHref`, causing it to render as a `div` with an `onClick` handler that includes
`e.stopPropagation()`. This setup creates conflicting behaviors. When a user clicks the
link, it's ambiguous whether the link's navigation will be prevented by the parent's
click handler, or if both the navigation and the `onAction` handler will fire, leading
to an inconsistent and potentially broken user experience.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not ideal but i want the app linked since ppl wont have it installed

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fac47d7. Configure here.

@billyvg billyvg merged commit 931509d into master May 28, 2026
79 checks passed
@billyvg billyvg deleted the billy/feat-replay-add-superuser-open-in-sentry-replay-debugger branch May 28, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants