fix(issues): Render ANSI colors in issue text#116404
Draft
scttcper wants to merge 1 commit into
Draft
Conversation
ANSI escape codes were showing up literally in exception values, messages, and breadcrumb text. Add a shared renderer that parses ANSI at display time and keeps URLs going through Sentry's external-link modal. Also replace the old ansi-to-react attachment viewer path with the vendored renderer so we do not keep raw anchor/linkify behavior around. Refs #116110 Co-Authored-By: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANSI escape codes were showing up literally in exception values, message interfaces, and breadcrumb text. This adds a shared ANSI renderer that parses the display string into React spans, maps standard colors through the Sentry theme, and keeps URLs going through Sentry's external-link modal.
This also vendors the small ansi-to-react path we still needed for attachment logs, with the BSD notice preserved, so we can drop the package and avoid raw anchor/linkify behavior.
Fixes #116110