ref(rpc): log from _make_rpc_request#116408
Merged
Merged
Conversation
Move the request logging from `_make_rpc_requests` to `_make_rpc_request`. It was already logging one line per request, and this way we can also log for callers who call `_make_rpc_request` directly. 🤖: The typing got a little nasty and I used Claude Code (Opus 4.6) to resolve the issues.
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0f296a6. Configure here.
wmak
approved these changes
May 28, 2026
Member
wmak
left a comment
wmak
left a comment
There was a problem hiding this comment.
🤔 lets just wrap the whole thing in a try/except so nothing breaks from logging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the request logging from
_make_rpc_requeststo_make_rpc_request, which it delegates each individual request to. We were already logging one line per RPC request, and this way we will also log for callers who call_make_rpc_requestdirectly.🤖: The typing got a little nasty and I used Claude Code (Opus 4.6) to resolve the issues.