-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(heatmaps): very small y-axis values turning into engineering notation and throwing errors #116421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nikkikapadia
merged 4 commits into
master
from
nikki/fix/heat-map-tooltip-formatting-error
May 28, 2026
Merged
fix(heatmaps): very small y-axis values turning into engineering notation and throwing errors #116421
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Precision loss silently rounds sub-1e-20 values to zero
Low Severity
_format_long_floatuses:.20fformatting, which only provides 20 decimal places. For values smaller than ~5×10⁻²¹, the formatted result rounds to all zeros (0.00000000000000000000), and afterrstrip("0").rstrip(".")the function silently returns'0'instead of the actual value. This would produce incorrect bucket boundaries in the query without any error signal.Reviewed by Cursor Bugbot for commit f72abe6. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
welp echarts won't process decimals over 20 places anyways so