fix(replays): Query canonical replay id in trace tab#116432
Open
romtsn wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.59% |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
romtsn
force-pushed
the
rz/fix/replay-trace-span-query
branch
from
b50c6e9 to
64922d9
Compare
The Replay trace tab now queries spans using replay.id while preserving the legacy replayId tag fallback. This lets trace discovery work for SDKs that rely on Relay/Snuba replay context propagation instead of the JavaScript-specific replayId tag. Refs REPLAY-915 Co-Authored-By: Codex <noreply@openai.com>
romtsn
force-pushed
the
rz/fix/replay-trace-span-query
branch
from
64922d9 to
1d78ee0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix replay trace discovery after the Trace tab switched to the spans dataset.
The Replay Trace tab still queried spans with only the legacy
replayIdtag. That misses SDK data where the replay id is propagated through the canonical span field asreplay.idinstead of the JavaScript-specific tag.Query both
replay.idandreplayIdso new canonical span data works while preserving compatibility with older JavaScript/legacy data. Apply the same query and spans dataset to the replay trace metadata pre-query, otherwise non-JS SDKs can load the trace list while missing metadata counts.I also checked the existing
replayalias, but it is not active for this request path in production, so the query stays explicit.Refs REPLAY-915