fix(webhooks): Check webhooks:enabled in new webhook path#116459
Merged
Conversation
The new legacy webhook sending path (send_legacy_webhooks_for_invocation) was missing the enabled/disabled check that the old plugin path enforces via plugin.is_enabled(). This meant webhooks would fire even for projects where webhooks are disabled when the new-path feature flag is on.
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we want to maintain the parity of being able to enable/disable legacy_webhooks on a per project basis we need to add back the gate that checks the webhooks:enabled ProjectOption