fix(replays): Stop page reloads on initial tab change#116494
Merged
nsdeschenes merged 2 commits intoMay 29, 2026
Merged
Conversation
Replay detail tabs only update side-panel UI state. Keep t_main URL updates shallow so switching tabs does not trigger a React Router navigation that can reset playback state. Co-Authored-By: Codex <noreply@openai.com>
Add coverage that replay detail tab changes still write t_main while opting into shallow URL updates over the app default. Co-Authored-By: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.59% |
billyvg
approved these changes
May 29, 2026
nsdeschenes
deleted the
nd/JAVASCRIPT-3A1R/fix-replays-page-reloads-on-tab-changes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to be an issue with nuqs on the initial tab change doing a fairly hefty page reload. To resolve this issue, we need to make the change "shallow".
Closes JAVASCRIPT-3A1R