feat(dashboards): Track dashboard generation validation attempts#116502
Merged
DominikB2014 merged 1 commit intoMay 29, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
Emit a sentry_sdk distribution metric, dashboards.on_completion_hook. generation_attempts, exactly once per dashboard generation when it reaches a terminal outcome (pass, max_retries, no_artifact). The value is the number of attempts (retry_count + 1) and tags carry status (pass|fail), result (pass|max_retries|no_artifact), and last_layer (pydantic|serializer) when result=max_retries. Lets dashboards answer how many tries the model needs to generate a valid dashboard, success rate over time, and which validator layer the model gets stuck on. _within_retry_budget split into _count_retries (pure counter) plus an inline budget check at the two failure branches, so the attempt count is available for the metric. The existing max_retries_reached log is preserved alongside. Co-Authored-By: Claude <noreply@anthropic.com>
DominikB2014
force-pushed
the
dominikbuszowiecki/track-dashboard-generation-retry-metric
branch
from
2d8a22d to
32823bb
Compare
DominikB2014
deleted the
dominikbuszowiecki/track-dashboard-generation-retry-metric
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add metrics to track dashboard validation attemps
resolved https://linear.app/getsentry/issue/DAIN-1700/track-retries-for-dashboard-artifact-generation