feat(markdown): add tag extension#116504
Open
natemoo-re wants to merge 4 commits into
Open
Conversation
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedType assertions (
This is informational only and does not block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Markdoc-style tag lexer extension to the core
Markdowncomponent. This is the foundation for rendering Seer's structured output (entity refs, artifacts) as rich, interactive embeds inline in the markdown stream instead of plain text.Two tag syntaxes via a
markedtokenizer extension registered globally on the lexer:{% ref type="issue" id="PROJ-123" /%}—inline within text{% artifact type="root-cause" %}{"description":"..."}{% /artifact %}—standalone or inline, with a JSON body merged intovalueTag names match
[\w-]+(valid HTML element identifiers); component-specific rendering (ref,artifact, etc.) will happen in the consumer registry as a follow-up.levelon the token reflects wheremarkedparsed it (blockvsinlinecontext).Partial tag syntax (
{% ref type="issue") is stripped unconditionally in thetexttoken handler to avoid displaying raw source text when streaming. No issues with false positives in code spans/blocks since those use thecodetokens.The
Tagcomponent slot inMarkdownComponentsfollows the sameWithDefaultpattern as every other component override.DefaultTagreturnsnull— the registry that maps tag names to concrete components will happen in a follow-up.Syntax
Inline ref (self-closing, no body)
Block ref (with snapshot data)
Artifact (always block-level)
Attributes go on the opening tag (
type,id). Complex data goes in the JSON body. They merge into a singlevalueobject for the renderer — attrs first, then JSON body.