feat(autofix): Link linear ticket in autofix PR#116510
Conversation
When creating autofix PRs, make sure to link the linear ticket so it'll be closed too.
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| for external_issue in PlatformExternalIssue.objects.filter(group_id=group.id): | ||
| if external_issue.service_type == "linear": | ||
| is_valid = bool(re.match(r"^[A-Z]{1,10}#\d+$", external_issue.display_name)) |
There was a problem hiding this comment.
why is this needed? how could it be invalid?
There was a problem hiding this comment.
Mostly being defensive as I wasn't sure where the display name is computed and this was a cheap check to add.
| lines.append(f"Fixes {group.qualified_short_id}") | ||
|
|
||
| for external_issue in PlatformExternalIssue.objects.filter(group_id=group.id): | ||
| if external_issue.service_type == "linear": |
There was a problem hiding this comment.
are there other platforms we'd want to do this for? might as well add JIRA, etc too right?
There was a problem hiding this comment.
I took a look but JIRA is done via another mechanism so I didnt want to bloat this PR with more logic. I can followup later 👍
JoshFerge
left a comment
JoshFerge
left a comment
There was a problem hiding this comment.
not sure about that cursor comment
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 540af71. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
2 participants
When creating autofix PRs, make sure to link the linear ticket so it'll be closed too.