Skip to content

chore(webhooks): Remove raise that short circuit url sending#116534

Merged
Christinarlong merged 1 commit into
masterfrom
crl/remove-raise-for-certain-errors
May 29, 2026
Merged

chore(webhooks): Remove raise that short circuit url sending#116534
Christinarlong merged 1 commit into
masterfrom
crl/remove-raise-for-certain-errors

Conversation

@Christinarlong
Copy link
Copy Markdown
Contributor

There's a small discrepancy rn where the number of webhooks being sent via task is > the number of plugin webhooks......
I'm kinda trial and erroring rn, and I think this could be one of the spots since we short circuit if 1 url is bad

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 29, 2026
@Christinarlong Christinarlong marked this pull request as ready for review May 29, 2026 22:09
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fa2bedb. Configure here.

Comment thread src/sentry/plugins/sentry_webhooks/plugin.py
Comment thread src/sentry/plugins/sentry_webhooks/plugin.py
@Christinarlong Christinarlong requested a review from a team May 29, 2026 22:13
@Christinarlong Christinarlong merged commit b69202c into master May 29, 2026
62 of 64 checks passed
@Christinarlong Christinarlong deleted the crl/remove-raise-for-certain-errors branch May 29, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants