feat(performance): Add trace stack span evidence#116540
Draft
scttcper wants to merge 1 commit into
Draft
Conversation
Adds a reusable trace-path renderer and an interactive trace stack for performance span evidence. N+1 DB and slow DB issues now show the transaction path down to the relevant span, with expandable formatted SQL for the evidence. Also adds focused coverage for the trace path builder and stack interactions. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
Contributor
📊 Type Coverage Diff
🔍 7 new type safety issues introducedNon-null assertions (
Type assertions (
This is informational only and does not block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a reusable trace path helper and an interactive trace stack for performance span evidence. N+1 DB and slow DB issues can now show the path from transaction down to the relevant span, with expandable formatted SQL for the evidence.
Also keeps the old key/value evidence around underneath for now while we try the stack-style version.