fix(sdk-crash): Ignore CoreData tracker as only SDK frame#116556
Open
philprime wants to merge 2 commits into
Open
fix(sdk-crash): Ignore CoreData tracker as only SDK frame#116556philprime wants to merge 2 commits into
philprime wants to merge 2 commits into
Conversation
Add SentryCoreDataTracker and SentryCoreDataSwizzlingHelper to the Cocoa SDK's sdk_crash_ignore_when_only_sdk_frame_matchers. These frames swizzle NSManagedObjectContext save:/executeFetchRequest: to add tracing spans and transparently call the original implementation. Crashes inside CoreData internals (doesNotRecognizeSelector: during merge policy or validation) are app-level misconfigurations, not SDK bugs. Fixes SDK-CRASHES-COCOA-59A
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8133f80. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Move SentryCoreDataSwizzlingHelper to sdk_crash_ignore_matchers (unconditional) so it doesn't inflate the conditional frame count. The detector only suppresses when conditional_sdk_frame_count == 1, but CoreData stacks always have both the helper and tracker frames. By unconditionally ignoring the helper, only SentryCoreDataTracker remains as the single conditional frame. Also add missing @patch decorator to test mixin.
romtsn
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
SentryCoreDataTrackerandSentryCoreDataSwizzlingHelperto the Cocoa SDK'ssdk_crash_ignore_when_only_sdk_frame_matchers, preventing false-positive SDK crash reports when these instrumentation frames are the only SDK frames in the stack.Context
SDK-CRASHES-COCOA-59A has 50K+ occurrences of
NSInvalidArgumentException(doesNotRecognizeSelector:) where the crash originates inside CoreData internals — merge policy constraint resolution or validation logging — not in our SDK code. Our CoreData swizzling transparently wrapssave:/executeFetchRequest:with tracing spans and calls the original implementation unchanged. The crashes would occur identically without our swizzling.This follows the same pattern as the existing
SentrySwizzleWrapperexclusion.Changes
FunctionAndModulePatternentries forSentryCoreDataTrackerandSentryCoreDataSwizzlingHelperCocoaSDKCoreDataTrackerTestMixinwith two tests:Fixes SDK-CRASHES-COCOA-59A
#skip-changelog