ref(pr-metrics): Scope sender and SHA fields to payload types that need them#119000
Merged
Conversation
…ed them Remove sender_login, sender_type, head_sha, and base_sha from BaseActivityPayload and push them down to only the payload types that actually carry those fields. AutoMergeEnabled/Disabled, Enqueued, and Dequeued payloads never used sender or SHA context; CheckSuite/CheckRun payloads don't expose sender or head SHA either. Update _build_activity_payload to use a sender_kw dict (without SHA fields) and pass head_sha/base_sha only to OpenedPayload. Remove sender_login/sender_type/head_sha from CheckSuiteCompletedPayload and CheckRunCompletedPayload construction. Drop now-unused sender variables in handle_check_suite and handle_check_run. Update tests to no longer assert head_sha or sender_type on check suite and check run activity rows. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
github-actions
Bot
added
the
Scope: Backend
vaind
approved these changes
Jul 3, 2026
vaind
left a comment
vaind
left a comment
Contributor
There was a problem hiding this comment.
Looks like a good candidate for Mixin but i'm fine with the current state too
Contributor
Author
|
Oh great idea, actually. Let's do that. |
…der identity Replace the repeated sender_login/sender_type field pair across twelve payload classes with a SenderMixin dataclass. Payload types that don't record sender context (CheckSuite, CheckRun, AutoMerge, Enqueued, Dequeued) are unchanged. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces the size of
PullRequestActivityrows by removing fields from the stored JSON payload that specific event types don't need.sender_login,sender_type,head_sha, andbase_shaare moved out of the base payload class and into only the individual payload types that actually use them.Refs CORE-265