Skip to content

ref: Graduate organizations:on-demand-metrics-ui (frontend) #119151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cvxluo wants to merge 1 commit into from
+2 −5
Closed

ref: Graduate organizations:on-demand-metrics-ui (frontend) #119151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions static/app/utils/onDemandMetrics/features.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@ export function hasOnDemandMetricAlertFeature(organization: Organization) {

export function shouldShowOnDemandMetricAlertUI(organization: Organization) {
// we want to show the UI only for orgs that can create new on-demand metric alerts
return (
hasOnDemandMetricAlertFeature(organization) &&
organization.features.includes('on-demand-metrics-ui')
);
return hasOnDemandMetricAlertFeature(organization);
}

export function hasOnDemandMetricWidgetFeature(organization: Organization) {
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/detectors/datasetConfig/transactions.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe('DetectorTransactionsConfig', () => {

it('on-demand success (apdex) returns METRICS_ENHANCED and prefixed query', () => {
const orgWithFeature = OrganizationFixture({
features: ['on-demand-metrics-extraction', 'on-demand-metrics-ui'],
features: ['on-demand-metrics-extraction'],
});

const key = DetectorTransactionsConfig.getSeriesQueryOptions({
Expand Down
Loading