Skip to content

feat(email): Pass project in querystring where relevant#12062

Merged
lynnagara merged 4 commits into
masterfrom
feat/email-links
Feb 15, 2019
Merged

feat(email): Pass project in querystring where relevant#12062
lynnagara merged 4 commits into
masterfrom
feat/email-links

Conversation

@lynnagara

Copy link
Copy Markdown
Member

Email links preselect the correct project where relevant. Passing an
active project filtes also ensures that default will be applied to the
environment and datetime values and prior selections will not be used.

Email links preselect the correct project where relevant. Passing an
active project filtes also ensures that default will be applied to the
environment and datetime values and prior selections will not be used.
@lynnagara lynnagara requested a review from a team February 14, 2019 01:00
<br />
{% if transaction %}
<span class="event-subtitle">{{ transaction }}</span>
{% endif %}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation here makes the template harder to read than how it was before.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh prettier does this, will fix

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add a .prettierignore file with *.html

@lynnagara lynnagara requested a review from a team February 14, 2019 22:10
@lynnagara lynnagara merged commit 52f38d4 into master Feb 15, 2019
@lynnagara lynnagara deleted the feat/email-links branch February 15, 2019 18:10
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants