fix(percy) Dismiss assistant in project releases visual test#12635
Merged
Conversation
I've been noticing an assistant cue appearing inconsistently on the project without releases visual test. We can get more stable results by ensuring the assistant has been dismissed first.
billyvg
approved these changes
Apr 4, 2019
| self.browser.wait_until('.ref-project-releases') | ||
| self.browser.snapshot('project releases without releases') | ||
|
|
||
| def dismiss_assistant(self): |
Member
There was a problem hiding this comment.
Is this something we want as a method in AcceptanceTestCase? Or maybe just disable entirely on the frontend?
Member
Author
There was a problem hiding this comment.
Disabling on the front-end would save us time from having to disable the assistant, but adds behavior that only exists in selenium which seems not great.
Adding a method to AcceptanceTestCase could work. We'd need a parameter for which assistant(s) need dismissal. I'm not sure I like dismiss_assistant(2) though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been noticing an assistant cue appearing inconsistently on the project without releases visual test. We can get more stable results by ensuring the assistant has been dismissed first.