ref: Use defaults for start and end times to Snuba

[manuzope]

We have the following logic in a few places:

snuba.raw_query(
    start=datetime.utcfromtimestamp(0),  # will be clamped to project retention
    end=datetime.utcnow(),  # will be clamped to project retention
    ...
)

However, we have some pretty reasonable defaults for start and end, so, let's use them.

[tkaemming]

Looks good, thanks — hard to believe nobody did this earlier. 😬

[tkaemming]

Using kwargs like this is kind of an anti-pattern but since you didn't introduce it, it is probably better to remain consistent with the existing code and not increase the scope of the change, so this is okay. Mostly pointing this out to say please don't take this as an example of good coding practice

[manuzope]

Good to know! When I do want to extract arguments from kwargs, is it better to extract it in the params?

get_group_tag_keys_and_top_values(...start=None, end=None)

[tkaemming]

Yes — for example in this case, if end=xyz was accidentally replaced with stop=xyz or some other invalid argument, the method would accept the invalid keyword argument, but not use it. This makes it difficult to identify incorrect usage, especially when refactoring