test(js): Fix console.errors from <NarrowLayout>#15058
Merged
Merged
Conversation
jsdom does not like tests trying to redirect. Change to use `window.location.assign` so we can mock them in tests
leedongwei
approved these changes
Oct 11, 2019
jan-auer
added a commit
that referenced
this pull request
Oct 14, 2019
* master: (405 commits) ref(ui): Add invite members panel (#15040) feat(dev): Add more post-merge suggestions (#15046) test(js): Fix console.errors from `<NarrowLayout>` (#15058) feat(apm): Display the op name for the top-level root span of the transaction. (#15057) perf(db): Cache positive/negative hits on Group being assigned during owner assignment. (#15049) chore(tagstore): Remove SnubaCompatibilityTagStorage (#15033) feat(api): Monkeypatch Django Migrations to have various safety features fix: Fix None-deref (#15052) perf(db): Get GroupSnooze from cache for notifactions hot path. (#15048) fix(ingest): Always count message towards batch (#15053) fix(event processing): Extend data scrubbing to all user attributes (#14812) fix(minidump): Catch msgpack TypeError (#15054) ref(signals): Process event_filtered and event_dropped in outcomes consumer exclusively (#15031) ref(ingest): Use batching-kafka-consumer (#15010) perf(db): Explicitly rebind Organization alongside Project. (#15041) feat(apm): Add APM for `<OrganizationDetails>` and `<ProjectsD… (#14960) ref(ui): Allow audit log filters to be cleared (#15038) py3(django): fix a few Django 1.9 deprecation warnings (#15025) ref(members): Disable roles that cannot be invited (#15037) fix(member-invite): Provide roles for admins using the invite modal (#14989) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsdom does not like tests trying to redirect. Change to use
window.location.assignso we can mock them in tests