Skip to content

fix(SnubaEvent): Fix bug in get_minimal_user #16231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lynnagara merged 1 commit into from
Jan 3, 2020
Merged

fix(SnubaEvent): Fix bug in get_minimal_user #16231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/sentry/models/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,15 +437,12 @@ def get_minimal_user(self):
email = self.snuba_data["email"]
username = self.snuba_data["username"]
ip_address = self.snuba_data["ip_address"]
else:
user_id = self.data["user_id"]
email = self.data["email"]
username = self.data["username"]
ip_address = self.data["ip_address"]
Comment on lines -440 to -444
Copy link
Contributor

@fpacifici fpacifici Jan 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I get why this did actually not work.

Copy link
Member Author

@lynnagara lynnagara Jan 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These properties are actually nested under self.data["user"] if they are present, this just gave a KeyError. The EventCommon implementation get_interface("user") takes care of loading them properly.


return User.to_python(
{"id": user_id, "email": email, "username": username, "ip_address": ip_address}
)
return User.to_python(
{"id": user_id, "email": email, "username": username, "ip_address": ip_address}
)

return super(SnubaEvent, self).get_minimal_user()

# If the data for these is available from snuba, we assume
# it was already normalized on the way in and we can just return
Expand Down