ref(ui): Added tooltip - Datascrubbers v2 - Part 11#17099
Merged
priscilawebdev merged 16 commits intoFeb 24, 2020
Conversation
priscilawebdev
force-pushed
the
refactor/datascrubbers-v2-added-tooltip-part-11
branch
from
40ed709 to
57f88c5
Compare
priscilawebdev
changed the title
priscilawebdev
changed the title
billyvg
reviewed
Feb 19, 2020
billyvg
left a comment
billyvg
left a comment
Member
There was a problem hiding this comment.
The spacing between ID: 1 seems a bit too close compared to the others.
Member
Author
|
@billyvg Thank you for your feedback. I believe that all of them should have the same |
markstory
reviewed
Feb 20, 2020
Member
|
@priscilawebdev The screenshot I posted was from Percy, the left is the original which looks good, the right is the diff so it's a bit harder to see, here is what it looks like The margin right does not look consistent here with |
priscilawebdev
commented
Feb 21, 2020
Member
Author
|
@billyvg it should be fine now ;-) |
billyvg
approved these changes
Feb 21, 2020
priscilawebdev
deleted the
refactor/datascrubbers-v2-added-tooltip-part-11
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Refactor
Description:
You can read more about this refactor here: https://app.asana.com/0/1155078590577881/1158903109364929
Result:
