feat(discover/issue search) Move all aggregates and aliases to functions#17392
Merged
Conversation
Consolidate all the aggregates and field aliases into functions in event_search, and add a shim to discover to translate any old queries into the new syntax.
markstory
reviewed
Mar 2, 2020
markstory
reviewed
Mar 2, 2020
| ["argMax", ["id", "timestamp"], "latest_event"], | ||
| ["max", "timestamp", "last_seen"], | ||
| ["apdex(duration, 300)", None, "apdex"], | ||
| ["apdex(duration, 300)", None, "apdex_transaction_duration_300"], |
Member
There was a problem hiding this comment.
Do we need to update the front-end alias generation to reflect this change?
Member
Author
There was a problem hiding this comment.
Yes, these two alias functions will need to be kept in sync. Right now if I map old functions to new functions, I also map the results back to the original alias passed in by the frontend.
markstory
approved these changes
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate all the aggregates and field aliases into functions in event_search,
and add a shim to discover to translate any old queries into the new syntax.