ref(ecosystem): remove old integration code#17823
Merged
Merged
Conversation
added 2 commits
March 20, 2020 17:45
NisanthanNanthakumar
approved these changes
Mar 23, 2020
Contributor
NisanthanNanthakumar
left a comment
NisanthanNanthakumar
left a comment
There was a problem hiding this comment.
Did you need to fix any tests? I'm pretty sure some might be broken or not needed now.
Contributor
Author
|
@NisanthanNanthakumar I removed some spec files in this PR as the file they were testing was removed. But as you see, the build passes so nothing is failing. |
…old-integration-code/API-830
… of github.com:getsentry/sentry into ref/remove-old-integration-code/API-830
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the integration directory experiment was successful and we no longer show the old views, a lot of components are no longer needed. This PR removes those components and removes some unneeded functionality from other components. Also removed some prop types because everything using those components is in Typescript :)