Skip to content

feat(deps): Upgrade to typescript@3.8#18265

Merged
billyvg merged 4 commits into
masterfrom
feat/deps/upgrade-typescript-3.8
Apr 15, 2020
Merged

feat(deps): Upgrade to typescript@3.8#18265
billyvg merged 4 commits into
masterfrom
feat/deps/upgrade-typescript-3.8

Conversation

@billyvg

@billyvg billyvg commented Apr 15, 2020

Copy link
Copy Markdown
Member

See changelog here: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html

* Type-Only Imports and Exports
* ECMAScript Private Fields
* export * as ns Syntax
* Top-Level await
* JSDoc Property Modifiers
* Better Directory Watching on Linux and watchOptions
* “Fast and Loose” Incremental Checking
* Type-Only Imports and Export

* Arbitrary data to track
*/
data: {[key: string]: number | string | boolean}
data: {[key: string]: any}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why new typescript causes this to fail, but it complains because data be string[], number[], Aggregation[]

@billyvg billyvg requested a review from a team April 15, 2020 02:18
@billyvg billyvg merged commit 2ccb02f into master Apr 15, 2020
@billyvg billyvg deleted the feat/deps/upgrade-typescript-3.8 branch April 15, 2020 21:48
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants