refs(subscriptions): Update subscriptions to support v2 format. Log request data.#18648
Merged
Conversation
…equest data. As part of investigating some data inconsistencies we want to log the details of the query we made. We've updated the payload format to support this. We should stop using the raw dict at some point and convert it into an object, but until we get time there's a hack in place for compatibility.
tkaemming
approved these changes
May 6, 2020
tkaemming
left a comment
tkaemming
left a comment
Contributor
There was a problem hiding this comment.
Not super familiar with the test structure here but the structure and parsing changes look accurate to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of investigating some data inconsistencies we want to log the details of the query we made.
We've updated the payload format to support this.
We should stop using the raw dict at some point and convert it into an object, but until we get time
there's a hack in place for compatibility.