Closed
Conversation
This replaces the usage of `<AlertMessage>` in spans interface that was added in #18025. It was not obvious, but `<AlertMessage>` should only be used in the `<Alerts>` component (e.g. via the Alerts store and not directly). There will be some follow-up PRs that address this, as this has been a common question.
* feat(ui): Add errors to release header * feat(ui): Add last deploy to release details * feat(ui): Deploy on detail page use Tag component * feat(ui): Change other projects in this release to ProjectBadge * feat(ui): Hide release errors from the UI * feat(ui): Add environment into last deploy tooltip
We used memcached instead of Redis in projectconfig debouncing which led to deletes not being visible to some other machines. While fixing this bug I investigated where I got that code from, and added comments to that code, shy of just deleting it.
Consolidate and normalize the ? icon + tooltip pattern we have in a few places. I've pulled in the hover effect from one of the implementations and also made form field icons 2px smaller as 18px is not a standard icon size for us.
Add a placeholder/loading state for user stats so we don't reflow the layout as data loads.
New for breadcrumbs feature - IconFire and IconFix Updated for breadcrumbs feature - IconTerminal
- Reduce snapshot to 1 minute (should reduce total filesize) - Update to 0.1.1 which supports upstream maskAllInputs configuration
Instead return a 400 as the client has made a request we don't want to answer. Fixes SENTRY-GBY
We are resetting cursor in globalSelection, which is nice, however we should not do that for initial load, because then you can't link to a specific page.
* ref(ts): Convert `app/views/app` to typescript * fixes to make types pass * update types
This PR adds the ability to sort releases by Active users.
…18773) Improvements on the releases overview page: Sort projects inside release card Replace n/a with a dash
These are not re-usable components, they are containers to display alerts messages that [generally] come from django. As such, these components are moved and renamed to be closer to where they are used. There are also changes required in `getsentry`
This chart has been moved to the sidebar. We aren't using this chart and don't need it anymore.
Previously, FeatureManager was able to receive feature handlers from plugins, which was used as a way to inject arbitrary handlers but not to associate them significantly with plugins. It entailed extra performance overhead in retrieving all other plugins, or an extra layer of abstraction to avoid doing so. For those reasons, replace it with a single, global registry of FeatureHandler objects. In ProjectSerializer, roll back use of the FeatureChecker abstraction because we now expect direct calls to `features.has` to be equally performant. Also some incidental cleanup in ProjectSerializer.
…cessor. (#18775) This fixes an issue where the aggregate name unintentionally changed and it broke the subscription consumer. I originally implemented this code to use the name explicitly, in case we start receiving mulitple values at some point. I don't see any reason that this will be happening any time soon, so just assuming a single value and grabbing it instead. This should be less brittle when we're migrating data. Fixes SENTRY-GCR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP -- needs tests.