refs(subscriptions): Use more fields from snuba_query to replace fields on the alert rule.#18780
Merged
Merged
Conversation
wedamija
changed the title
snuba_query to replace fi…snuba_query to replace fields on the alert rule.
wedamija
added a commit
that referenced
this pull request
May 13, 2020
…nship We now fetch these rows via the `snuba_query`. We also add in a migratio to remove constraints from several through tables that we'll be removing soon. Depends on #18780
wedamija
force-pushed
the
danf/use_snuba_query_fields
branch
from
8f432be to
a6b7a7e
Compare
wedamija
force-pushed
the
danf/use_more_snuba_query_fields
branch
from
b9427ce to
8778954
Compare
iProgramStuff
approved these changes
May 13, 2020
…elds on the alert rule. This continues the work from #18751. This converts most of the fields in Sentry to use this new model. Will follow this up with a pr to remove the old fields.
wedamija
force-pushed
the
danf/use_more_snuba_query_fields
branch
from
8778954 to
943db61
Compare
wedamija
added a commit
that referenced
this pull request
May 14, 2020
…nship We now fetch these rows via the `snuba_query`. We also add in a migratio to remove constraints from several through tables that we'll be removing soon. Depends on #18780
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the work from #18751. This converts most of
the fields in Sentry to use this new model. Will follow this up with a pr to remove the old fields.