refs(alert_rules): Stop using query related fields on AlertRule and QuerySubscription. Remove unused columns from models, and unused Models#18805
Merged
Conversation
Member
Author
|
Migration generates: |
wedamija
force-pushed
the
danf/stop_using_query_subscriptions
branch
2 times, most recently
from
6b2d8b6 to
8d214e8
Compare
wedamija
force-pushed
the
danf/alert_rules_drop_columns
branch
from
dfc3091 to
a8bd178
Compare
wedamija
force-pushed
the
danf/stop_using_query_subscriptions
branch
from
8d214e8 to
fa24a26
Compare
wedamija
force-pushed
the
danf/alert_rules_drop_columns
branch
from
a8bd178 to
2a2473a
Compare
wedamija
changed the base branch from
danf/stop_using_query_subscriptions
to
master
wedamija
force-pushed
the
danf/alert_rules_drop_columns
branch
from
2a2473a to
153b23c
Compare
…uerySubscription. Remove unused columns from models, and unused Models This removes all query related fields from both `AlertRule` and `QuerySubscription`, since we can now rely solely on `SnubaQuery`. This also removes the *Environment many to many tables, since these are also unused. This migration only removes them from the state - we'll add another migration later to really remove the colums and unused tables. As part of this pr we remove and final outstanding uses of these columns and tables as well.
wedamija
force-pushed
the
danf/alert_rules_drop_columns
branch
from
153b23c to
56658c6
Compare
markstory
approved these changes
May 14, 2020
markstory
left a comment
markstory
left a comment
Member
There was a problem hiding this comment.
Migration state changes look good.
iProgramStuff
approved these changes
May 14, 2020
iProgramStuff
left a comment
iProgramStuff
left a comment
Contributor
There was a problem hiding this comment.
Looks like you got everything to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all query related fields from both
AlertRuleandQuerySubscription, since we cannow rely solely on
SnubaQuery. This also removes the *Environment many to many tables, since theseare also unused. This migration only removes them from the state - we'll add another migration later to really remove the columns and unused tables.
As part of this pr we remove any final outstanding uses of these columns and tables as well.