feat(discover2): Add per cell action to count_unique() #19382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashed
force-pushed
the
discover-add-per-cell-action-to-count_unique
branch
from
a43e502 to
4360bca
Compare
markstory
approved these changes
Jun 16, 2020
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Would be good to add tests for the new cell action type.
Member
Author
|
I'll follow up with a PR to add some acceptance tests for the per-cell actions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add per-cell action to
count_unique(), the last remaining Discover column to yet have a per-cell action.