fix(py): Specify celery memory broker broker url correctly.#19842
Merged
Conversation
In Celery 3.x it seems fine to just specify the `memory` backend and set `BROKER_URL=None`. In Celery 4.x this ends up defaulting to a url like `amqp:...`, which causes a failure when we attempt to flush the queue after each test. Luckily, all we need to do is specify the url like `memory://` and it is correctly picked up again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Celery 3.x it seems fine to just specify the
memorybackend and setBROKER_URL=None. InCelery 4.x this ends up defaulting to a url like
amqp:..., which causes a failure when we attemptto flush the queue after each test. Luckily, all we need to do is specify the url like
memory://and it is correctly picked up again.
This change works fine in both Celery 3.x and 4.x