fix(ui-components): adds skip_load_on_open field and adds migration#20078
Merged
fix(ui-components): adds skip_load_on_open field and adds migration#20078
Conversation
| "type": {"type": "string", "enum": ["select"]}, | ||
| "label": {"type": "string"}, | ||
| "name": {"type": "string"}, | ||
| "async": {"type": "boolean"}, |
Member
There was a problem hiding this comment.
do you think we could add these options in the test_issue_link test?
Contributor
Author
There was a problem hiding this comment.
@MeredithAnya Which test is this? can't find it.
Member
There was a problem hiding this comment.
validators/sentry_apps/test_issue_link.py p sure
Contributor
Author
There was a problem hiding this comment.
@MeredithAnya My bad, I didn't realize it was a file. Yes, I will update it.
Member
|
If someone from @getsentry/owners-migrations could give this some 👀 that would be good, I think overall this looks good to me tho |
added 2 commits
July 29, 2020 15:59
wedamija
reviewed
Jul 29, 2020
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
I don't know the logic here so can't comment on that, but the migration looks safe, only 64 rows and so should be fine to run on deploy.
MeredithAnya
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the
asyncfield we have for UI components does not behave in the way that the docs explain. It turns out the only thing it actually does is skip loading the options when the page first loads (instead, it waits until the user starts typing). This PR fixes this issue by doing the following:asyncfield properly in that it controls whether we fetch more options when the user types. In order to maintain legacy behavior, the default value istrue.skip_load_on_openwhich acts the same was asasyncdid before.asynctoskip_load_on_openin order to maintain the current form behavior for existing applications.As far as the migration goes, the
SentryAppComponenttable is pretty small.Docs PR to go with this: getsentry/sentry-docs#1930