fix(monitoring): Update amqp API#20640
Merged
Merged
Conversation
When switching from librabbitmq to py-amqp, the Connection API changed slightly. Both libraries accept the kwarg `host` with the form of `host=host[:port]` but only librabbitmq accepted `host=host, port=port`. In py-amqp the port was being lost. So this swaps to the format that works for both.
wedamija
approved these changes
Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching from librabbitmq to py-amqp, the Connection API changed
slightly.
Both libraries accept the kwarg
hostwith the form ofhost=host[:port]but only librabbitmq acceptedhost=host, port=port.In py-amqp the port was being lost.
So this swaps to the format that works for both.