ci(gcb): Fix GCB failures due to missing extra $$ #21370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to #21360 as it failed to address the underlying issue. GCB uses the `$xxx` syntax for variable expansion and it opreates in 'loose' mode when a trigger runs the build. This means it simply replaces unknown substitions with empty strings. This collides with how we try to use env variables which has the same syntax so the need to use `$$` syntax for GCB to not replace them with empty strings.
jan-auer
approved these changes
Oct 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #21360 as it failed to address the underlying issue. GCB uses the
$xxxsyntax for variable expansion and it opreates in 'loose' mode when a trigger runs the build. This means it simply replaces unknown substitions with empty strings. This collides with how we try to use env variables which has the same syntax so the need to use$$syntax for GCB to not replace them with empty strings.